New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Member::highest_role_info to Guild::member_highest_role #2816

Merged

arqunis merged 2 commits into serenity-rs:current from GnomedDev:better-role

Mar 25, 2024

Member

GnomedDev commented Mar 25, 2024

This means:

PartialGuild::greater_member_hierarchy isn't a duplicate of Guild::greater_member_hierarchy anymore
Guild::greater_member_hierarchy doesn't need the cache parameter, and this can be removed in a followup PR to next.
Guild::member_highest_role doesn't need cache and can return back a reference to the role, instead of id and position which then required another lookup.

GnomedDev added 2 commits

March 25, 2024 20:38


          De-duplicate PartialGuild::greater_member_hierarchy

7948fcb


          Move Member::highest_role_info to Guild::member_highest_role

c7c7232

github-actions bot added the model label

arqunis approved these changes

View reviewed changes

arqunis added the enhancement label

arqunis merged commit d29962d into serenity-rs:current

22 checks passed

GnomedDev deleted the better-role branch

March 25, 2024 20:57

GnomedDev mentioned this pull request

Remove deprecated Member and Guild methods #2817

Merged

arqunis added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

bc96494

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

78c884b

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

69c3cb8

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

38cde2f

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

0850f85

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

fcd79bd

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

76bf89d

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

fa8f39d

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

08db97d

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

a818c36

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

5a9339e

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

8f1a2b0

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

15585e8

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

386e985

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

48c9846

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

c584dee

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

c0e0771

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit to GnomedDev/serenity that referenced this pull request


          Remove deprecated Member and Guild methods (serenity-rs#2817)

d4413f4

Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

GnomedDev added a commit that referenced this pull request


          Remove deprecated Member and Guild methods (#2817)

3acb21e

Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement model