Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiple event handler support #2849

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Remove multiple event handler support #2849

merged 1 commit into from
Apr 24, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Apr 24, 2024 •
edited
Loading

As voted for on the lib dev channel: this removes multiple event handler support and restores the owned values passed to event handlers.

@github-actions github-actions bot added client Related to the `client` module. gateway Related to the `gateway` module. labels Apr 24, 2024
@github-actions github-actions bot added the examples Related to Serenity's examples. label Apr 24, 2024
@github-actions github-actions bot added model Related to the `model` module. cache Related to the `cache`-feature. labels Apr 24, 2024
@GnomedDev GnomedDev force-pushed the single-event branch 3 times, most recently from 3128cc9 to 06b9713 Compare April 24, 2024 12:59
@GnomedDev GnomedDev marked this pull request as ready for review April 24, 2024 13:05
@GnomedDev
Copy link
Member Author

Ready for review.

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Apr 24, 2024
@GnomedDev GnomedDev merged commit 44586a6 into serenity-rs:next Apr 24, 2024
21 checks passed
@GnomedDev GnomedDev deleted the single-event branch April 24, 2024 18:47
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
689a2b6
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove multiple event handler support (#2849)
a5fbdb1
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove multiple event handler support (#2849)
3f01b43
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove multiple event handler support (#2849)
ad3eb13
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
3d50a65
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove multiple event handler support (#2849)
960b565
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
5daf84d
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Remove multiple event handler support (serenity-rs#2849)
840f954
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Remove multiple event handler support (serenity-rs#2849)
67901b9
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Remove multiple event handler support (#2849)
6d82937
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
99cb8bc
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
454cc6c
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Remove multiple event handler support (#2849)
9662f7d
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 11, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
7afefd5
GnomedDev added a commit that referenced this pull request Nov 13, 2024
@GnomedDev
Remove multiple event handler support (#2849)
a93686f
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@GnomedDev
Remove multiple event handler support (serenity-rs#2849)
ef23ef3
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@GnomedDev @mkrasnitski
Remove multiple event handler support (serenity-rs#2849)
9fdeb9d
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@GnomedDev @arqunis
Remove multiple event handler support (serenity-rs#2849)
208d2f0
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Remove multiple event handler support (serenity-rs#2849)
b242d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. client Related to the `client` module. enhancement An improvement to Serenity. examples Related to Serenity's examples. gateway Related to the `gateway` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis