Add support for premium buttons #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
mkrasnitski
force-pushed
the
premium-buttons
branch
from
094134a
to
01d4c17
Compare
|
Are there any use cases for the store link without a SKU? If there are, it may be worth implementing it, otherwise, it is fine to be left out IMO. |
|
The store link does in fact get rendered as a rich embed too (docs), however I don't really know which struct would be best suited to have a method that returns the url. |
|
Both could either have an additional method, or make the existing Alternatively, or additively, |
|
Sorry for the delay, should be good for merge now. |
mkrasnitski
force-pushed
the
premium-buttons
branch
from
55181e0
to
0678c3b
Compare
arqunis
approved these changes
Jul 25, 2024
arqunis
added
enhancement
jamesbt365
pushed a commit
to jamesbt365/serenity
that referenced
this pull request
Jul 29, 2024
Fixes serenity-rs#2904 This adds support for the new premium buttons that replace the `PREMIUM_REQUIRED` interaction response type, which has been deprecated.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 7, 2024
serenity-rs#2928) This was deprecated on `current` in serenity-rs#2905, so it can be removed here on `next`.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Oct 20, 2024
serenity-rs#2928) This was deprecated on `current` in serenity-rs#2905, so it can be removed here on `next`.
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
serenity-rs#2928) This was deprecated on `current` in serenity-rs#2905, so it can be removed here on `next`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2904
Adds support for the new premium buttons that replace the
PREMIUM_REQUIREDinteraction response type, which has been deprecated.