Replace outdated secrecy library with own impl #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
force-pushed
the
no-more-secretstring
branch
2 times, most recently
from
d9d53c4 to
7e8e193
Compare
GnomedDev
force-pushed
the
no-more-secretstring
branch
from
7e8e193 to
68f1bf6
Compare
jamesbt365
approved these changes
Oct 21, 2024
jamesbt365
reviewed
Oct 21, 2024
Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 11, 2024
`secrecy` has had major changes in it's transition from `0.8` -> `0.10` that would make it even less useful than it is now. This just brings the basic implementation in-house and exposes it publicly, which is somehow less lines of code that trying to use the `0.8` API, let alone `0.10`. --------- Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
`secrecy` has had major changes in it's transition from `0.8` -> `0.10` that would make it even less useful than it is now. This just brings the basic implementation in-house and exposes it publicly, which is somehow less lines of code that trying to use the `0.8` API, let alone `0.10`. --------- Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
GnomedDev
added a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
`secrecy` has had major changes in it's transition from `0.8` -> `0.10` that would make it even less useful than it is now. This just brings the basic implementation in-house and exposes it publicly, which is somehow less lines of code that trying to use the `0.8` API, let alone `0.10`. --------- Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
`secrecy` has had major changes in it's transition from `0.8` -> `0.10` that would make it even less useful than it is now. This just brings the basic implementation in-house and exposes it publicly, which is somehow less lines of code that trying to use the `0.8` API, let alone `0.10`. --------- Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secrecyhas had major changes in it's transition from0.8->0.10that would make it even less useful than it is now.This just brings the basic implementation in-house and exposes it publicly, which is somehow less lines of code that trying to use the
0.8API, let alone0.10.