Add EditCommand builder
#3028
Merged
Add EditCommand builder
#3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
approved these changes
Nov 12, 2024
Comment on lines
+335
to
+336
| #[serde(flatten)] | ||
| fields: EditCommand<'a>, |
There was a problem hiding this comment.
I like this, a lot. We should do this more.
GnomedDev
pushed a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
pushed a commit
to GnomedDev/serenity
that referenced
this pull request
Nov 15, 2024
This separates the the builders for creating versus editing a command, since it's not possible to change the `type` of a command (in serenity this is the `kind` field). Also, the `name` field is not required when editing a command.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Dec 8, 2024
This separates the the builders for creating versus editing a command, since it's not possible to change the `type` of a command (in serenity this is the `kind` field). Also, the `name` field is not required when editing a command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the the builders for creating versus editing a command, since it's not possible to change the
typeof a command (in serenity this is thekindfield). Also, thenamefield is not required when editing a command.