Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customizable wait time on shard queuer #3031

Merged
merged 6 commits into from
Nov 13, 2024
Merged

customizable wait time on shard queuer #3031

merged 6 commits into from
Nov 13, 2024

Conversation

cheesycod
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the gateway Related to the `gateway` module. label Nov 12, 2024
jamesbt365
jamesbt365 reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think its clear enough that in normal cases you should not change the shard start time (as this will rate limit you).

@cheesycod
Copy link
Contributor Author

I don't think its clear enough that in normal cases you should not change the shard start time (as this will rate limit you).

True, will try adding a warning to the builder function

GnomedDev
GnomedDev requested changes Nov 12, 2024
View reviewed changes
src/gateway/client/mod.rs Outdated Show resolved Hide resolved
@cheesycod cheesycod requested a review from GnomedDev November 12, 2024 20:54
@jamesbt365 jamesbt365 force-pushed the wait-time-configurable-next branch from ed8ffc4 to ea54360 Compare November 13, 2024 01:12
@GnomedDev GnomedDev merged commit 46c6311 into serenity-rs:next Nov 13, 2024
21 checks passed
@jamesbt365 jamesbt365 mentioned this pull request Nov 13, 2024
Closed
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Nov 15, 2024
@cheesycod @GnomedDev
Add config for the shard start wait time (serenity-rs#3031)
e9238dd 
Co-authored-by: Gnome! <david2005thomas@Gmail.com>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Dec 8, 2024
@cheesycod @GnomedDev @mkrasnitski
Add config for the shard start wait time (serenity-rs#3031)
b70b905 
Co-authored-by: Gnome! <david2005thomas@Gmail.com>
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2025
@cheesycod @GnomedDev @arqunis
Add config for the shard start wait time (serenity-rs#3031)
a17ecb7 
Co-authored-by: Gnome! <david2005thomas@Gmail.com>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@cheesycod @GnomedDev @mkrasnitski
Add config for the shard start wait time (serenity-rs#3031)
1b61046 
Co-authored-by: Gnome! <david2005thomas@Gmail.com>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 14, 2025
@cheesycod @GnomedDev @mkrasnitski
Add config for the shard start wait time (serenity-rs#3031)
e2b5fcc 
Co-authored-by: Gnome! <david2005thomas@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbt365 jamesbt365 jamesbt365 left review comments

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees
No one assigned
Labels
gateway Related to the `gateway` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheesycod @jamesbt365 @GnomedDev