Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some clippy warnings #924

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Address some clippy warnings #924

merged 2 commits into from
Jul 29, 2020

Conversation

dmarcoux
Copy link
Contributor

No description provided.

Dany Marcoux added 2 commits July 29, 2020 21:50
Address warnings for clippy::option_as_ref_deref
736e6aa 
The warnings were like this:

called `.as_ref().map(String::as_str)` on an Option value. This can be
done more directly by calling `query.as_deref()` instead
Address warning for clippy::iter_nth_zero
2ee4915 
The warning was like this:

called `.nth(0)` on a `std::iter::Iterator`
@arqunis arqunis added enhancement An improvement to Serenity. client Related to the `client` module. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. labels Jul 29, 2020
@arqunis arqunis merged commit 2a54410 into serenity-rs:current Jul 29, 2020
@dmarcoux dmarcoux deleted the address-some-clippy-warnings branch July 29, 2020 20:20
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jul 29, 2020
@arqunis
Address some clippy warnings (serenity-rs#924)
92b5c39 
* Address warnings for `clippy::option_as_ref_deref`

The warnings were like this:

called `.as_ref().map(String::as_str)` on an Option value. This can be
done more directly by calling `query.as_deref()` instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
client Related to the `client` module. enhancement An improvement to Serenity. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarcoux @arqunis