Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye FixedOffset #935

Merged
merged 7 commits into from
Aug 20, 2020
Merged

Goodbye FixedOffset #935

merged 7 commits into from
Aug 20, 2020

Conversation

qm3ster
Copy link
Contributor

@qm3ster qm3ster commented Aug 20, 2020

Be very afraid, users will be broken by:

  1. replacing DateTime<FixedOffset> with DateTime<Utc> everywhere
  2. BucketBuilder methods taking u64 not i64

Look through the commits though, there might be something good 🤷🤷‍♂️🤷‍♀️

@qm3ster
Remove chrono from ratelimit buckets
e84723d 
Now unknown time is expressed as None, not magic timestamp 0

Breaking change: BucketBuilder methods take u64 not i64,
because negative duration doesn't make sense.
@qm3ster
Make number of invocations unsigned
06114d3
@qm3ster
Remove chrono from ws_client
ae3791b
@arqunis
Copy link
Member

arqunis commented Aug 20, 2020

Could you remove the last commit? I would prefer to apply cargo fmt on the repository in a separate PR.

@qm3ster
Copy link
Contributor Author

qm3ster commented Aug 20, 2020

Done.

@arqunis arqunis added dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Aug 20, 2020
@arqunis arqunis merged commit ed7b18e into serenity-rs:current Aug 20, 2020
@qm3ster qm3ster deleted the goodbye-chrono branch August 21, 2020 18:22
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 9, 2020
@qm3ster @arqunis
Remove usage of chrono in a few places and switch from FixedOffset to…
c9f935a 
… Utc (serenity-rs#935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qm3ster @arqunis