Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed position reporting bug #154

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fixed position reporting bug #154

merged 1 commit into from
Dec 14, 2022

Conversation

JamesDSource
Copy link
Contributor

Without this line resetting the position here, two things happen

  • When seeking backwards in a track, the reported position will just add the time you seek to itself
  • When a track loops, it does not reset it's position to 0 and will continue to overflow from it's end time

@JamesDSource JamesDSource changed the title Fixed bug posision reporting bug Fixed position reporting bug Nov 29, 2022
FelixMcFelix
FelixMcFelix approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this makes sense. Thanks!

@FelixMcFelix FelixMcFelix merged commit 39a6f69 into serenity-rs:current Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMcFelix FelixMcFelix FelixMcFelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesDSource @FelixMcFelix