Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilight 0.15 support #171

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Twilight 0.15 support #171

merged 2 commits into from
Apr 10, 2023

Conversation

Erk-
Copy link
Member

@Erk- Erk- commented Apr 8, 2023

This patch changes around quite a few things.
The main entry point for twilight besides process will now be the
TwilightMap which consists of command senders for each shard.

This simplifies parts of the code as there is not any difference
between shards and clusters anymore.

@Erk- Erk- requested a review from FelixMcFelix April 8, 2023 11:48
@Erk- Erk- changed the title Twilight v0 15 Twilight 0.15 support Apr 8, 2023
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just missing a cargo +nightly fmt --all according to CI.

src/ws.rs Outdated Show resolved Hide resolved
This patch changes around quite a few things.
The main entrypoint for twilight besides process will now be the
TwilightMap which concists of command senders for each shard.

This simplifies parts of the code as there is not any difference
between shards and clusters anymore.
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, good work. Thanks!

(CI failures are due to divergence from Serenity, unrelated to this as far as I know)

@FelixMcFelix FelixMcFelix merged commit db1fcb2 into serenity-rs:next Apr 10, 2023
FelixMcFelix pushed a commit to FelixMcFelix/songbird that referenced this pull request Nov 20, 2023
This patch changes around quite a few things.
The main entrypoint for twilight besides process will now be the
TwilightMap which concists of command senders for each shard.

This simplifies parts of the code as there is not any difference
between shards and clusters anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants