Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xsalsa20poly1305 with crypto_secretbox #198

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Replace xsalsa20poly1305 with crypto_secretbox #198

merged 5 commits into from
Jul 31, 2023

Conversation

Sebbl0508
Copy link
Contributor

xsalsa20poly1305 is listed as deprecated

FelixMcFelix
FelixMcFelix requested changes Jul 29, 2023
View reviewed changes
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wasn't aware that the library had been deprecated. There are some minor changes I'd like to ask for, otherwise I can see it's mostly a drop-in replacement.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/driver/crypto.rs Outdated Show resolved Hide resolved
src/driver/tasks/mixer.rs Outdated Show resolved Hide resolved
@Sebbl0508
Copy link
Contributor Author

I've adjusted the code. hope it looks good now

FelixMcFelix
FelixMcFelix approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me! Thank you. :)

@FelixMcFelix FelixMcFelix merged commit df8ee0f into serenity-rs:current Jul 31, 2023
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this pull request Aug 28, 2023
@Sebbl0508 @FelixMcFelix
Driver: Replace xsalsa20poly1305 with crypto_secretbox (serenity-…
139b685 
…rs#198)

As of v0.9.1, `xsalsa20poly1305` has been deprecated. This is a mostly seamless replacement, as it appears to be the same crate authors / code / etc.

Co-authored-by: Kyle Simpson <kyleandrew.simpson@gmail.com>
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this pull request Nov 20, 2023
@Sebbl0508 @FelixMcFelix
Driver: Replace xsalsa20poly1305 with crypto_secretbox (serenity-…
77a9b46 
…rs#198)

As of v0.9.1, `xsalsa20poly1305` has been deprecated. This is a mostly seamless replacement, as it appears to be the same crate authors / code / etc.

Co-authored-by: Kyle Simpson <kyleandrew.simpson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMcFelix FelixMcFelix FelixMcFelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sebbl0508 @FelixMcFelix