Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality checks page requires help/_ttk_quality_checks.html #431

Closed
julen opened this issue Mar 10, 2020 · 0 comments · Fixed by #435
Closed

Quality checks page requires help/_ttk_quality_checks.html #431

julen opened this issue Mar 10, 2020 · 0 comments · Fixed by #435
Labels
bug

Comments

@julen
Copy link
Contributor

julen commented Mar 10, 2020

Since Django 2.1, exceptions from {% include %} tags are not silenced anymore:

Silencing exceptions raised while rendering the {% include %} template tag is deprecated as the behavior is often more confusing than helpful. In Django 2.1, the exception will be raised

This means the help/quality_checks.html page will fail to load if help/_ttk_quality_checks.html is missing. The latter was generated as part of a build process.
@julen julen added the bug label Mar 10, 2020
julen added a commit to julen/zing that referenced this issue Mar 11, 2020
@julen
Checks: do not include TTK quality checks page
06adabc 
Because Zing uses its own set of checks already. Moreover, the page that
was trying to be included broke the page altogether because since Django
2.1 exceptions raised in templates are not silenced.

Fixes serge-community#431.
@julen julen mentioned this issue Mar 11, 2020
Merged
julen added a commit to julen/zing that referenced this issue Mar 11, 2020
@julen
Checks: do not include TTK quality checks page
1443a11 
Because Zing uses its own set of checks already. Moreover, the page that
was trying to be included broke the page altogether because since Django
2.1 exceptions raised in templates are not silenced.

Fixes serge-community#431.
@julen julen closed this as completed in d585c50 Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checks: do not include TTK quality checks page julen/zing
1 participant
@julen