-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Plurr preview for simple {FOO}-style placeholders #468
Comments
Since this ticket is similar to the Emoji Highlight ticket I'll take a look Plurr: Cross-platform format specification + libraries for handling plurals/genders/conditionals for Go, Java, JS, Obj-C, Perl, PHP, Python |
@iafan Do you have an example (unit) of a live Plurr preview panel? |
@benjamimo1 here you go: https://translate.evernote.com/ru/android_evernote/translate/strings.xml.po#unit=6140694 You can find such units in Zing by searching for |
Relevant paths:
|
@iafan can you reference a code line where "Right now we look for {FOO:<...>} " happens? |
Improved comments on regex Got comments mixed up. Fixed
Improved comments on regex Got comments mixed up. Fixed Fix serge-community#458: make emojis work as placeables. Fix serge-community#458: make emojis work as placeables.
Right now we look for
{FOO:<...>}
style placeholders in the string to determine whether we need to show the live Plurr preview panel. However, we could expand that to any strings that contain simple placeholders like{FOO}
as well, since these are also valid in Plurr (and Plurr can be used to render such strings even if they don't contain plurals or choices).Example of such a string:
The text was updated successfully, but these errors were encountered: