Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 2 #401

Merged
merged 16 commits into from
Jan 27, 2020
Merged

Upgrade to Django 2 #401

merged 16 commits into from
Jan 27, 2020

Conversation

julen
Copy link
Contributor

@julen julen commented Jan 24, 2020

Fixes #399

From the release notes:
> The on_delete argument for ForeignKey and OneToOneField is now
> required in models and migrations. Consider squashing migrations
> so that you have fewer of them to update

We're setting the argument value to `models.CASCADE` to keep the old
default behavior, i.e. there are no functional changes.
From the release notes:
> The load_template and load_template_sources template loader methods
> are removed.

In order to make this work, we are here inlining some of Django's
template loading internals.
This was accidentally removed in 923920e.
These were not properly adjusted in bcf95ae.
This is to ensure DB data dumps contain consistent user IDs upon
regeneration and hence we reduce the diff noise.
Because users will be created when setting up the DB, and the DB
creation autouse fixture is session-scoped, we need to make sure the
language fixture we require is session-scoped too.
From Django 2.2 release notes:
> The default truncation character used by the urlizetrunc,
> truncatechars, truncatechars_html, truncatewords, and truncatewords_html
> template filters is now the real ellipsis character (…) instead of 3
> dots. You may have to adapt some test output comparisons.
@julen julen merged commit 9ae6321 into serge-community:py3 Jan 27, 2020
@julen julen deleted the py3-django2 branch January 27, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant