-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 2 #401
Merged
Merged
Upgrade to Django 2 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the release notes: > The on_delete argument for ForeignKey and OneToOneField is now > required in models and migrations. Consider squashing migrations > so that you have fewer of them to update We're setting the argument value to `models.CASCADE` to keep the old default behavior, i.e. there are no functional changes.
From the release notes: > The load_template and load_template_sources template loader methods > are removed. In order to make this work, we are here inlining some of Django's template loading internals.
This was accidentally removed in 923920e.
These were not properly adjusted in bcf95ae.
This is to ensure DB data dumps contain consistent user IDs upon regeneration and hence we reduce the diff noise.
Because users will be created when setting up the DB, and the DB creation autouse fixture is session-scoped, we need to make sure the language fixture we require is session-scoped too.
* Django 2.1 moved the location of `wrap_label` Refs. https://docs.djangoproject.com/en/3.0/releases/2.1/#moved-wrap-label-widget-template-context-variable * New built-in view permission Refs. https://docs.djangoproject.com/en/3.0/releases/2.1/#model-view-permission
From Django 2.2 release notes: > The default truncation character used by the urlizetrunc, > truncatechars, truncatechars_html, truncatewords, and truncatewords_html > template filters is now the real ellipsis character (…) instead of 3 > dots. You may have to adapt some test output comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399