This repository has been archived by the owner on Jul 28, 2020. It is now read-only.
upgrade packages and implementation to v2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodxa
suggested changes
Aug 5, 2018
src/index.js
Outdated
| @@ -1,14 +1,15 @@ | |||
| import Router from 'next/router' | |||
There was a problem hiding this comment.
We should receive Router as argument on line 5 and then pass it too withGa and withFBQ.
When trying to import next/router directly on the dependency caused Router to be undefined always.
There was a problem hiding this comment.
Completely agreed! I've updated the PR passing the router as a param instead of a dependency.
sergiodxa
approved these changes
Aug 6, 2018
|
Great, will publish under v2 today |
|
🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.