Replace let with const in README.md snippets #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most TS & JS linters (e.g. ESLint) enforce that `const` is used for any variables which don't get reassigned. This updates the README snippets so that copying them doesn't trigger lint errors.
|
Thanks but I prefer let over const, changing to const if your linter enforce it should be a quick automated fix, it could even happen on save or on paste based on your config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most TS & JS linters (e.g. ESLint) enforce that
constis used for any variables which don't get reassigned. This updates the README snippets so that copying them doesn't trigger lint errors.