Replace Array#at with array[I] to support more browsers #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodxa
changed the title
sergiodxa
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally figured out the #207 issue.
I was actually dealing with two different issues, not just one. The first one was fixed in the PR that you approved. It was about parsing the
Accept-Language. However #207 still occurred in Sentry.I couldn't figure out the error at first, but today morning i realized it's not about reading undefined root loader but that
Array.prototype.atfunction is not supported in a lot of non-standard browsers.Sure, i couldn't care less about MuiBrowser, etc.. However my B2B platform is really important for people who sell online. Which means they provide links to my platform on Instagram, Facebook, etc.. And they use weird browsers which in Sentry appear just as
Instagram {version},Facebook {version}, etc.. And they don't support the.atfunction onArray🙃 (not always but many times if people don't update instagram)