Support SDL_WINDOW_FULLSCREEN_DESKTOP in SDL2 builds #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
reviewed
Aug 17, 2022
| @@ -59,6 +59,7 @@ void initializeVideo(uint8_t fastMode) | |||
| exit(1); | |||
| } | |||
|
|
|||
| // TODO: Use SDL_WINDOW_FULLSCREEN_DESKTOP in console ports? | |||
There was a problem hiding this comment.
I'd say we don't, since there is no concept of Desktop in them 🤔
| @@ -232,7 +233,7 @@ void toggleFullscreen() | |||
|
|
|||
| void setFullscreenMode(uint8_t fullscreen) | |||
| { | |||
| SDL_SetWindowFullscreen(gWindow, fullscreen ? SDL_WINDOW_FULLSCREEN : 0); | |||
| SDL_SetWindowFullscreen(gWindow, fullscreen ? SDL_WINDOW_FULLSCREEN_DESKTOP : 0); | |||
There was a problem hiding this comment.
Is there any consequence of this in scaling or rendering or does it Just Work© in any resolution the user has?
ftortoriello
added a commit
to ftortoriello/open-supaplex
that referenced
this pull request
Aug 23, 2024
Also, toggle full-screen mode only once if the key combination is kept pressed. Based on sergiou87#40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to switch display modes when toggling full-screen mode.