pythongh-111789: Use PyDict_GetItemRef() in Modules/pyexpat.c

serhiy-storchaka · Nov 14, 2023 · 774bb1c · 774bb1c
1 parent 0ff6368
commit 774bb1c
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c
@@ -240,19 +240,12 @@ string_intern(xmlparseobject *self, const char* str)
  return result;
  if (!self->intern)
  return result;
- value = PyDict_GetItemWithError(self->intern, result);
- if (!value) {
- if (!PyErr_Occurred() &&
- PyDict_SetItem(self->intern, result, result) == 0)
- {
- return result;
- }
- else {
- Py_DECREF(result);
- return NULL;
- }
+ if (PyDict_GetItemRef(self->intern, result, &value) == 0 &&
+ PyDict_SetItem(self->intern, result, result) == 0)
+ {
+ return result;
  }
- Py_INCREF(value);
+ assert((value != NULL) == !PyErr_Occurred());
  Py_DECREF(result);
  return value;
 }