Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing issue on Freebsd #254

Closed
skillcoder opened this issue Nov 6, 2013 · 3 comments
Closed

Installing issue on Freebsd #254

skillcoder opened this issue Nov 6, 2013 · 3 comments
Assignees

Comments

@skillcoder
Copy link

Latest "node" and "npm" from ports
npm 1.3.11
node v0.10.21

FreeBSD 9.1-RELEASE #2: amd64

npm install serialport

gmake: Вход в каталог `/server/node_modules/serialport/build'
  CXX(target) Release/obj.target/serialport/src/serialport.o
In file included from ../src/serialport.cpp:8:
../src/serialport_poller.h:33:7: warning: no newline at end of file
  CXX(target) Release/obj.target/serialport/src/serialport_unix.o
In file included from ../src/serialport_unix.cpp:3:
../src/serialport_poller.h:33:7: warning: no newline at end of file
../src/serialport_unix.cpp:681:7: warning: no newline at end of file
../src/serialport_unix.cpp: In function 'int ToBaudConstant(int)':
../src/serialport_unix.cpp:63: error: 'B500000' was not declared in this scope
../src/serialport_unix.cpp:64: error: 'B576000' was not declared in this scope
../src/serialport_unix.cpp:66: error: 'B1000000' was not declared in this scope
../src/serialport_unix.cpp:67: error: 'B1152000' was not declared in this scope
../src/serialport_unix.cpp:68: error: 'B1500000' was not declared in this scope
../src/serialport_unix.cpp:69: error: 'B2000000' was not declared in this scope
../src/serialport_unix.cpp:70: error: 'B2500000' was not declared in this scope
../src/serialport_unix.cpp:71: error: 'B3000000' was not declared in this scope
../src/serialport_unix.cpp:72: error: 'B3500000' was not declared in this scope
../src/serialport_unix.cpp:73: error: 'B4000000' was not declared in this scope
gmake: *** [Release/obj.target/serialport/src/serialport_unix.o] Ошибка 1
gmake: Выход из каталога `/server/node_modules/serialport/build'
gyp ERR! build error
gyp ERR! stack Error: `gmake` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:789:12)
gyp ERR! System FreeBSD 9.1-RELEASE
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /server/node_modules/serialport
gyp ERR! node -v v0.10.21
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok
npm ERR! weird error 1
npm ERR! not ok code 0
@ghost ghost assigned JayBeavers Nov 12, 2013
@JayBeavers
Copy link
Collaborator

If you look at the source, you'll see an ifdef around those higher speed baudrates:

#if !defined(__APPLE__) && !defined(__OpenBSD__)

Looks like you're either missing a define for OpenBSD or we need to add another condition to the code there.

I'm not running FreeBSD, @skillcoder could you take a pass at figuring out which is the right solution and submit a patch request with the fix?

JayBeavers added a commit to JayBeavers/node-serialport that referenced this issue Nov 12, 2013
@JayBeavers
Copy link
Collaborator

Does this patch fix your issue?

@JayBeavers
Copy link
Collaborator

I'm pretty certain #259 fixes your issue and has a low chance of regression, so I'm going to check that in and close this bug. Please let me know if you still experience the issue with the updated code.

This won't go out to npm immediately so you'll have to install from github to test.

JayBeavers added a commit that referenced this issue Nov 14, 2013
Swap ifdef around for high speed baud rates to fix #254
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
reconbot pushed a commit that referenced this issue Jul 24, 2018
Swap ifdef around for high speed baud rates to fix #254
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants