Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that on Windows OS vendorId always set to undefined #877

Closed
fduman opened this issue Jul 20, 2016 · 2 comments
Closed

It seems that on Windows OS vendorId always set to undefined #877

fduman opened this issue Jul 20, 2016 · 2 comments
Labels
feature-request Feature or Enhancement windows

Comments

@fduman
Copy link

fduman commented Jul 20, 2016

Operating System and Hardware: Windows 10
NodeJS Version: 5.10.0
Serialport version: 2.1.2

I use serialport's list method and I cannot get vendorId information from that function. I had to use the pnpId property.

It seems that serialport_win.cpp has no code to get the vendor id.

I can get the vendor id information on OS X and this is an inconsistent behavior.
@reconbot
Copy link
Member

This might be a bug.

We're using a library called http://github.com/todbot/usbSearch/ to find ports and get info. This area is ripe for cleaning them up.

@reconbot reconbot added windows feature-request Feature or Enhancement labels Jul 22, 2016
@Zensey
Copy link
Contributor

Zensey commented Nov 20, 2016

Also there is no productId and locationId

Zensey added a commit to Zensey/node-serialport that referenced this issue Nov 20, 2016
@Zensey
Refactoring of EIO_List for Windows: …
2768653 
1. use single API -- SetupAPI directly without COM-object
2. supply ResultItem with vendorId, productId and locationId (issue serialport#877)
3. solve problem with pnpId not beeing returned on some systems
@Zensey Zensey mentioned this issue Nov 20, 2016
Merged
Zensey added a commit to Zensey/node-serialport that referenced this issue Nov 20, 2016
@Zensey
Refactoring of EIO_List for Windows: …
96b37e2 
1. use single API -- SetupAPI directly without COM-object
2. supply ResultItem with vendorId, productId and locationId (issue serialport#877)
3. solve problem with pnpId not beeing returned on some systems
reconbot pushed a commit that referenced this issue Nov 28, 2016
@Zensey @reconbot
Refactoring of EIO_List for Windows: … (#1019)
29eb25f 
* Refactoring of EIO_List for Windows:  …
1. use single API -- SetupAPI directly without COM-object
2. supply ResultItem with vendorId, productId and locationId (issue #877)
3. solve problem with pnpId not being returned on some systems
reconbot pushed a commit that referenced this issue Nov 28, 2016
@Zensey @reconbot
Refactoring of EIO_List for Windows: … (#1019)
f24110b 
* Refactoring of EIO_List for Windows:  …
1. use single API -- SetupAPI directly without COM-object
2. supply ResultItem with vendorId, productId and locationId (issue #877)
3. solve problem with pnpId not being returned on some systems
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Feature or Enhancement windows
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reconbot @Zensey @fduman