Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and fix eslint config #2879

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Aug 16, 2024

Previously, npm install; npm run lint would fail. Now it succeeds.

This involved a couple changes:

  1. switch from eslint legacy to flat config
  2. bump some plugins, including removing some straggling references to the unmaintained eslint-plugin-node in favor of its sucessor eslint-plugin-n and removing eslint-plugin-import, which is unused and incompatible with eslint 9.
  3. Use the recommended config for typescript-eslint.
  4. Turn off the rule @typescript-eslint/no-require-imports, which currently fails on parts of the codebase.

@rotu rotu changed the title Upgrade/fix eslint config Upgrade and fix eslint config Aug 16, 2024
@reconbot
Copy link
Member

I really appreciate this, thank you. Fixing lockfile after the fact.

@reconbot reconbot merged commit 73a34f9 into serialport:main Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants