fix: linting #2966
Merged
fix: linting #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (9)
- .prettierignore: Language not supported
- .prettierrc: Language not supported
- package.json: Language not supported
- packages/list/tsconfig-build.json: Language not supported
- packages/list/tsconfig.json: Language not supported
- packages/terminal/tsconfig-build.json: Language not supported
- packages/terminal/tsconfig.json: Language not supported
- packages/parser-packet-length/lib/index.ts: Evaluated as low risk
- packages/parser-slip-encoder/lib/decoder.ts: Evaluated as low risk
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Eslint9 and stylistic mean we can ditch prettier, typscript specific rules, and a can revisit the whole eslint config.
reconbot
force-pushed
the
reconbot/fixup-eslint
branch
from
cd4c078 to
0fb9e2e
Compare
reconbot
commented
Dec 24, 2024
| @@ -1,4 +1,5 @@ | |||
| import { assert, use } from 'chai' | |||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | |||
| const { assert, use } = require('chai') | |||
There was a problem hiding this comment.
I think chai went to node modules and while this probably would have just worked typescript wouldn't stop complaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint9 and stylistic mean we can ditch prettier, typescript specific rules, and a can revisit the whole eslint config.