Upgrade to Nan 2.0.0 #566

ghostoy · 2015-08-22T12:11:46Z

Upgrade to Nan 2.0.0 to support latest io.js 3.x

ghostoy · 2015-08-22T13:34:01Z

Sorry. I don't know how to make Travis-CI work correctly. But it's built and tested ok on my Windows, Linux and Mac.

zzz6519003 · 2015-08-28T14:02:27Z

🍺 the commits can be squashed XD

rwaldron · 2015-09-07T16:26:37Z

The failure is io.js 3.0.0 specific—maybe @rvagg can take a look and offer some insight.

rvagg · 2015-09-07T23:46:35Z

this is a compiler incompatibility, Travis runs on Ubuntu 12.04 and therefore has a GCC that doesn't support the newer C++ functionality being embraced by V8, so you need to upgrade it (tbh I don't know about clang and I see you have compiler: clang in there but I'm guessing it's similar). What other projects have done to make this work is add the following:

addons:
  apt:
    sources:
    - ubuntu-toolchain-r-test
    packages:
    - g++-4.8

Then under install add the following at the top of the list:

  - if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
  - $CXX --version

(the "linux" case there is helpful if you're adding the experimental osx support travis have made available).

On your builds you should see a gcc version of 4.8. Probably remove the clang bit while you're there.

rwaldron · 2015-09-08T19:25:13Z

Thanks @rvagg

rwaldron · 2015-09-10T14:37:11Z

src/win/stdstring.h

@@ -63,7 +63,7 @@
 //			- Jim Cline
 //			- Jeff Kohn
 //			- Todd Heckel
-//			- Ullrich Poll�hne
+//			- Ullrich Poll�hne


ChALkeR · 2015-09-10T19:05:34Z

Adding to the list: nodejs/node#2798.

ghostoy · 2015-09-11T12:59:22Z

Disabled 32bit build and dropped 0.8 because node-pre-gyp doesn't support 0.8 anymore.

ghostoy · 2015-09-13T10:39:17Z

Bring back x86 builds on Travis-CI.

jacobrosenthal · 2015-09-14T20:41:08Z

src/serialport.cpp


  OpenBaton* baton = new OpenBaton();
  memset(baton, 0, sizeof(OpenBaton));
  strcpy(baton->path, *path);
-  baton->baudRate = options->Get(NanNew<v8::String>("baudRate"))->ToInt32()->Int32Value();


why remove all ->Get?

It's not removed. It's replace with Nan::Get, which is said to be compatible with all V8 versions.

The double ToLocalChecked seems redundant and expensive, are you sure its needed?

ToLocalChecked is introduced by the new Maybe types, which fails at the point of null value. And there is another counterpart ToLocal which doesn't do the check. I think the current convention is assuming options->Get always return non-NULL value. So ToLocalChecked is the safest replacement.

imyller · 2015-09-18T05:35:47Z

👍 Travis CI passed. Good to go?

mgcrea · 2015-09-21T08:46:13Z

Looking forward to have this merged to use with latest node stable.

fivdi · 2015-09-26T10:18:36Z

I performed some tests with this PR on the BeagleBone Black with two different test setups.

Debian Wheezy, gcc/g++ 4.6, Node.js v0.10.38
Result: installed successfully and a simple test ran successfully
Debian Jessie, gcc/g++ 4.9, Node.js v4.1.1
Result: installed successfully and a simple test ran successfully

jacobrosenthal · 2015-09-30T00:47:01Z

src/serialport.cpp

-  baton->hupcl = options->Get(NanNew<v8::String>("hupcl"))->ToBoolean()->BooleanValue();
-
-  v8::Local<v8::Object> platformOptions = options->Get(NanNew<v8::String>("platformOptions"))->ToObject();
+  baton->baudRate = Nan::Get(options, Nan::New<v8::String>("baudRate").ToLocalChecked()).ToLocalChecked()->ToInt32()->Int32Value();


@ghostoy talking about this double tolocalchecked. Are we sure it needs to be checked twice?

It's not being, the "baudRate" v8::String is being checked first and then the v8::Value that results from the Nan::Get() has to be converted too.

See https://nodesource.com/blog/cpp-addons-for-nodejs-v4 for some details on MaybeLocal types and why this garbage is needed (in short: blame Haskell).

voodootikigod · 2015-10-02T13:24:30Z

This is missing the infrastructure update/buildout for Windows. That needs to be done in the appveyor.yml file. Will see if I can handle the update.

jacobrosenthal · 2015-10-11T20:19:31Z

Squashed, rebased and commited as 866e415

Cong Liu added 6 commits August 22, 2015 19:50

Upgrade to Nan 2.0.0

29bc318

Fixed build errors on Linux

511e2a8

Fixed for Node.js 0.12

ad5f9aa

Fixed for Node.js 0.12 Linux

bc44bf8

Fixed for Node.js 0.10 Linux

5d9506b

Added io.js 3.0.0 in Travis-CI

913d18f

ghostoy force-pushed the nan1to2 branch 3 times, most recently from 38ede95 to 913d18f Compare August 22, 2015 13:19

imyller mentioned this pull request Sep 7, 2015

Problems to install on IOJS #573

Closed

fivdi mentioned this pull request Sep 8, 2015

Regular meetings? nodejs/hardware#16

Closed

vielmetti mentioned this pull request Sep 8, 2015

Node 4.0.x support node-red/node-red#721

Closed

rwaldron reviewed Sep 10, 2015
View reviewed changes

Fix an encoding issue

56cbe61

rvagg mentioned this pull request Sep 11, 2015

Update to nan2 and node 3+ APIs Automattic/node-canvas#622

Merged

Updated travis script

edc22a7

jacobrosenthal mentioned this pull request Sep 12, 2015

State of nodejs 4.0 support - ie NOT supported until this closed #578

Closed

Added x86 test

a7e2dac

jacobrosenthal reviewed Sep 14, 2015
View reviewed changes

Cleaned travis script

09658df

This was referenced Sep 24, 2015

I have the same issue #594

Closed

Build Failed with OSX10.9.5 and Ubuntu14.04? #595

Closed

jacobrosenthal reviewed Sep 30, 2015
View reviewed changes

sweetpi mentioned this pull request Oct 1, 2015

[pimatic] Strategy for migration to node v4.x pimatic/pimatic#719

Closed

jacobrosenthal closed this Oct 11, 2015

jacobrosenthal mentioned this pull request Oct 13, 2015

upgrade to NAN v2 #571

Closed

lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Nan 2.0.0 #566

Upgrade to Nan 2.0.0 #566

ghostoy commented Aug 22, 2015

ghostoy commented Aug 22, 2015

zzz6519003 commented Aug 28, 2015

rwaldron commented Sep 7, 2015

rvagg commented Sep 7, 2015

rwaldron commented Sep 8, 2015

rwaldron Sep 10, 2015

ChALkeR commented Sep 10, 2015

ghostoy commented Sep 11, 2015

ghostoy commented Sep 13, 2015

jacobrosenthal Sep 14, 2015

ghostoy Sep 15, 2015

jacobrosenthal Sep 15, 2015

ghostoy Sep 16, 2015

imyller commented Sep 18, 2015

mgcrea commented Sep 21, 2015

fivdi commented Sep 26, 2015

jacobrosenthal Sep 30, 2015

rvagg Sep 30, 2015

voodootikigod commented Oct 2, 2015

jacobrosenthal commented Oct 11, 2015

Upgrade to Nan 2.0.0 #566

Upgrade to Nan 2.0.0 #566

Conversation

ghostoy commented Aug 22, 2015

ghostoy commented Aug 22, 2015

zzz6519003 commented Aug 28, 2015

rwaldron commented Sep 7, 2015

rvagg commented Sep 7, 2015

rwaldron commented Sep 8, 2015

rwaldron Sep 10, 2015

Choose a reason for hiding this comment

ChALkeR commented Sep 10, 2015

ghostoy commented Sep 11, 2015

ghostoy commented Sep 13, 2015

jacobrosenthal Sep 14, 2015

Choose a reason for hiding this comment

ghostoy Sep 15, 2015

Choose a reason for hiding this comment

jacobrosenthal Sep 15, 2015

Choose a reason for hiding this comment

ghostoy Sep 16, 2015

Choose a reason for hiding this comment

imyller commented Sep 18, 2015

mgcrea commented Sep 21, 2015

fivdi commented Sep 26, 2015

jacobrosenthal Sep 30, 2015

Choose a reason for hiding this comment

rvagg Sep 30, 2015

Choose a reason for hiding this comment

voodootikigod commented Oct 2, 2015

jacobrosenthal commented Oct 11, 2015