Transform parsers into streams #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| port.write('ROBOT PLEASE RESPOND\n'); | ||
|
|
||
| // this can be shortened to | ||
| var SerialPort = require('serialport'); |
reconbot
force-pushed
the
parser-streams
branch
from
c2e1f2e to
f60121b
Compare
|
I'm not wanting to merge this without restoring the |
reconbot
force-pushed
the
parser-streams
branch
4 times, most recently
from
418dfaf to
bf903e8
Compare
Parsers are now transform streams! I'm not 100% convinced this is easier to use but it is more clear about the mechanics. I think that might make it worthwhile. It also opens up a clear example to how to make your own parser.
reconbot
force-pushed
the
parser-streams
branch
from
bf903e8 to
d2bb973
Compare
reconbot
added a commit
that referenced
this pull request
Jul 24, 2018
Transform parsers into streams
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsers are now transform streams!
I'm not 100% convinced this is easier to use but it is more clear about the mechanics. I think that might make it worthwhile. It also opens up a clear example to how to make your own parser.