Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for providing splunkHost as-is? #205

Closed
VictorioBerra opened this issue May 21, 2024 · 5 comments
Closed

Allow for providing splunkHost as-is? #205

VictorioBerra opened this issue May 21, 2024 · 5 comments
Assignees
Labels
bug component-HEC Semver-Patch Patch Update - non-breaking changes
Milestone

Comments

@VictorioBerra
Copy link
Member

My config today is:

    "WriteTo": [
      {
        "Name": "EventCollector",
        "Args": {
          "splunkHost": "https://splunk.example.com/services/collector",
          "eventCollectorToken": "111-222-333"
        }
      }
    ],

splunkHost has the path, and is in our KeyVaults.

I noticed this changed with 4.0.0.

Is there a way to avoid changing splunkHost? For example, the fix I want to avoid:

    "WriteTo": [
      {
        "Name": "EventCollector",
        "Args": {
          "splunkHost": "https://splunk.example.com",
          "uriPath": "/services/collector",
          "eventCollectorToken": "111-222-333"
        }
      }
    ],
@EEParker
Copy link
Collaborator

Good idea. The splunkHost argument could probably be parsed and split to uriPath if it contains the subpaths.

@EEParker
Copy link
Collaborator

EEParker commented Jun 5, 2024

@VictorioBerra I just pushed a bugfix branch for this, I believe this was unintended operation. If you can test out the patch, I will roll that in with this 5.0 release that also updates Serilog to 4.0

https://www.nuget.org/packages/Serilog.Sinks.Splunk/5.0.0-dev-00073

@EEParker EEParker added the bug label Jun 5, 2024
@EEParker EEParker self-assigned this Jun 5, 2024
@EEParker EEParker added this to the 5.0 milestone Jun 5, 2024
@EEParker EEParker added Semver-Patch Patch Update - non-breaking changes and removed enhancement Semver-Minor Minor Update - non-breaking changes labels Jun 5, 2024
EEParker added a commit that referenced this issue Jun 5, 2024
* Fix for #205 allow collector path in host url

* Remove redundant check
@VictorioBerra
Copy link
Member Author

I will get this tested shortly

@EEParker
Copy link
Collaborator

Did you get a chance to test this? @VictorioBerra

@VictorioBerra
Copy link
Member Author

Did you get a chance to test this? @VictorioBerra

Yes I did, it worked great thank you! I replied a while ago here: #211 (comment)

I should have replied to the issue here though, sorry about that.

@EEParker EEParker closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component-HEC Semver-Patch Patch Update - non-breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants