Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Allow to report errors to the module through a less intrusive mechanism #61

Merged
merged 4 commits into from
Feb 28, 2019

Conversation

tsimbalar
Copy link
Member

fixes #48

  • Introduces new extension methods under namespace SerilogWeb.Classic.Extensions, mainly to be used by SerilogWeb.CLassic.WebAPI for WebApi global ExceptionHandler always returns HTML instead of JSON when package SerilogWeb.Classic.WebApi is present in project classic-webapi#16 :
    • HttpContext.AddSerilogWebError(Exception exception) / HttpContextBase.AddSerilogWebError(Exception exception)
    • HttpContext.GetLastSerilogWebError() / HttpContextBase.GetLastSerilogWebError()
  • bump referenced Serilog version to v2.7.1 (published 9 month ago) . (v2.8.0 is only a month old, and forcing unnecessary update cold be annoying to end user)
  • bump package version to v5.0 . Not really a breaking change but may introduce subtle behavior different when combined with secondary packages (WebAPI one)

in a less intrusive way than doing `HttpContext.AddError`

fixes serilog-web#48
Because that feels like a big enough change
We might as well update it. v2.8 is still a bit fresh, and we don't want to force undesired package updates ...
@tsimbalar tsimbalar merged commit f6c90f3 into serilog-web:master Feb 28, 2019
@tsimbalar tsimbalar deleted the feat/error-reporting branch February 28, 2019 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass an exception to the "logging module" through other means than HttpContext.AddError
1 participant