Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin .NET Core SDK version to latest feature band #165

Merged

Conversation

ralphhendriks
Copy link
Contributor

Pin the .NET Core SDK version to the 3.1.1xx feature band. Do not allow prerelease versions.

Pinning to the feature band (e.g. 3.1.1xx) seems to give the right trade off between build consistency and developer friendliness.

Also, since C# 7.3 is the default language version for netstandard2.0, it is not necessary to explicitly specify it.

Pin the .NET Core SDK version to the `3.1.1xx` feature band. Do not
allow prerelease versions.

Also, since C# 7.3 is the default language version for `netstandard2.0`,
it is not necessary to explicitly specify it.
@nblumhardt nblumhardt merged commit 56418c3 into serilog:dev Feb 24, 2020
@nblumhardt
Copy link
Member

Thanks! 👍

@ralphhendriks ralphhendriks deleted the relax-gloabl-json-sdk-constraints branch February 24, 2020 22:16
@nblumhardt nblumhardt mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants