Make property set logic robust to irregular properties

serilog · Aug 3, 2024 · df8c383 · df8c383
1 parent 04d694d
commit df8c383
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Serilog.Settings.Configuration/Settings/Configuration/ObjectArgumentValue.cs b/src/Serilog.Settings.Configuration/Settings/Configuration/ObjectArgumentValue.cs
@@ -185,12 +185,14 @@ bool TryCallCtor(Type type, Dictionary<string, IConfigurationSection> suppliedAr
                         }
                         else
                         {
-                            return new { ci, args, isCallable = false, matches, stringMatches, suppliedNames };
+                            return new { ci, args, isCallable = false, matches, stringMatches,
+                                usedArguments = suppliedNames };
                         }
                     }
                 }
 
-                return new { ci, args, isCallable = true, matches, stringMatches, suppliedNames };
+                return new { ci, args, isCallable = true, matches, stringMatches,
+                    usedArguments = suppliedNames };
             })
             .Where(binding => binding.isCallable)
             .OrderByDescending(binding => binding.matches)
@@ -217,7 +219,11 @@ bool TryCallCtor(Type type, Dictionary<string, IConfigurationSection> suppliedAr
 
         foreach (var pi in type.GetProperties(BindingFlags.Instance | BindingFlags.Public))
         {
-            if (!binding.suppliedNames.Contains(pi.Name) && suppliedArguments.TryGetValue(pi.Name, out var section) && pi.CanWrite)
+            if (!binding.usedArguments.Contains(pi.Name) &&
+                suppliedArguments.TryGetValue(pi.Name, out var section)
+                && pi.CanWrite &&
+                // This avoids trying to call esoteric indexers and so on.
+                pi.GetSetMethod(false)?.GetParameters().Length == 1)
             {
                 var propertyValue = FromSection(section, _configurationAssemblies);
                 try