.NET Framework: Configuring Enrichers from json does not work

[aFuerst]

Does this issue relate to a new feature or an existing bug?

• Bug
• New Feature

What version of Serilog is affected? Please list the related NuGet package.
Serilog, Version=2.0.0.0
Serilog.Enrichers.Process, Version=2.0.0.0
Serilog.Enrichers.Thread, Version=2.0.0.0
Serilog.Enrichers.Environment, Version=2.0.0.0
Serilog.Settings.Configuration, Version=2.6.1.0

What is the target framework and operating system? See target frameworks & net standard matrix.

• netCore 2.0
• netCore 1.0
• 4.7
• 4.6.x
• 4.5.x

Please describe the current behavior?
Enrichers configured via json configuration are not applied.
The created logger has an empty enricher.

Please describe the expected behavior?
The enrichers specified in the json config should be applied to the created logger and the data they are supposed to add gets put in the logs

If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem
This is the config section I have

"Serilog": {
	"Enrich": [ "FromLogContext", "WithMachineName", "WithProcessId", "WithThreadId", "WithExceptionDetails" ],
	"MinimumLevel": "Verbose",
	"WriteTo": [
		{
			"Name": "Trace",
			"Args": {
				"formatter": "Serilog.Formatting.Json.JsonFormatter, Serilog"
			}
		}
	],
	"Using": [ "Serilog.Sinks.Trace" ]
}

We're using the full .NET Framework.
The logger creation looks like this. We load it entirely from the IConfiguration object.

var logger = new LoggerConfiguration()
	.ReadFrom.Configuration(config)
	.CreateLogger();

[merbla]

@aFuerst are you missing a using in the settings for `Serilog.Enrichers.Environment?

"Using": [ "Serilog.Sinks.Trace", "Serilog.Enrichers.Environment" ]

[aFuerst]

@merbla That was it. Thank you!
I didn't realize I needed to add the namespaces to the Using since you didn't do that in the example in the ReadMe

[tsimbalar]

Actually the README says :

(This package implements a convention using DependencyContext to find any package with Serilog anywhere in the name and pulls configuration methods from it, so the Using example above is redundant.)

So we are actually saying that "Using" is not necessary for Serilog.* libraries, and the following code does it :

serilog-settings-configuration/src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs

Lines 297 to 302 in 74fb413

	AssemblyName[] GetSerilogConfigurationAssemblies()
	{
	// ReSharper disable once RedundantAssignment
	var query = Enumerable.Empty<AssemblyName>();
	var filter = new Func<string, bool>(name => name != null && name.ToLowerInvariant().Contains("serilog"));

So there is either a bug or an incorrect documentation issue here :)

[MV10]

Is there a test for that? Sounds like we need one if not.

[tsimbalar]

The sample app does not specify "Using" for WriteTo.Async or Enrich.WithMachineName that live in separate Nuget packages, so something is slightly wrong somewhere ....

[marco-gallinari]

We are experiencing the same issue adding serilog to a 4.6.1 web project via ninject.
The project is hosting a suite of wcf services, and we need to inject netstandard dependencies from other .net core projects.

The library is not loading enrichers nor sinks (File and Seq).

         kernel.Bind<ILoggerFactory>().ToMethod(context => {

                var conf = context.Kernel.Get<IConfiguration>();


                var loggerConfig = new LoggerConfiguration();

                loggerConfig.ReadFrom.Configuration(conf);

                return new LoggerFactory().AddSerilog(loggerConfig.CreateLogger(), true);

            }).InSingletonScope();
            kernel.Bind(typeof(ILogger<>)).To(typeof(Logger<>)).InSingletonScope();

It only works as soon as we add all namespaces (enrichers and sinks) to the "Using" property.

This could be an issue with the framework version, because the same json configuration works properly on our .net core projects.

[nblumhardt]

Ah, yes, the "Using" blocks are only redundant in Core, IIRC the dependency context works differently on Framework :-/