Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Destructure.AsScalar(Type scalarType) #120

Merged
merged 6 commits into from
Jul 18, 2018

Conversation

tsimbalar
Copy link
Member

Fixes #115

  • Support method arguments of type Type by converting from the type's qualified name
  • Add support for (non-extension) method Destructure.AsScalar
  • Add test to check that custom extension methods Destructure.XXX() can properly be invoked
  • Refactor ConfigurationReader by extracting all the surrogate method handling to a separate class

@tsimbalar tsimbalar merged commit 74fb413 into serilog:dev Jul 18, 2018
@MV10
Copy link
Contributor

MV10 commented Jul 20, 2018

@tsimbalar love that change to move the Surrogate methods to their own home. That ConfigurationReader class was getting a bit tangled-up...

@tsimbalar tsimbalar deleted the destructure-asscalar branch October 6, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants