Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom types in arrays and custom collections #203

Merged
merged 4 commits into from
Mar 25, 2020

Conversation

sungam3r
Copy link
Contributor

@sungam3r sungam3r commented Dec 7, 2019

Also:

  • add new test platforms and unify msbuild conditional properties
  • minor code cleanup
  • PackageIcon instead of PackageIconUrl
  • fix for simplified syntax on netcore3.0
  • fix SinkWithConfigurationBindingArgument test (wrong argument type)

relates to #201

add new test platforms and unify msbuild conditional properties
minor code cleanup
PackageIcon instead of PackageIconUrl
fix for simplified syntax on netcore3.0
fix SinkWithConfigurationBindingArgument test (wrong argument type)
@sungam3r
Copy link
Contributor Author

sungam3r commented Jan 5, 2020

@nblumhardt Any progress on this?

@nblumhardt
Copy link
Member

On the top of my review queue - sorry @sungam3r :-)

@sungam3r
Copy link
Contributor Author

sungam3r commented Mar 1, 2020

@nblumhardt friendly bump

@nblumhardt
Copy link
Member

Hi @sungam3r - I see a couple of comments above from @skomis-mm that could be addressed; I don't think changing TFMs or dependency versions is strictly necessary for the PR (or at least needs some discussion). Sergey is one of the primary authors of this package, so working with him to help spread the review effort around would be appreciated.

@sungam3r
Copy link
Contributor Author

@nblumhardt @skomis-mm I made the necessary changes.

Copy link
Contributor

@skomis-mm skomis-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sungam3r,

Looks good, thanks.
One thing is dealing with _configurationAssemblies around and passing it back and forth. I think when ResolutionContext was introduced it could be incapsulated there. But it wasn't. Probably worth to also refactor this so we don't need to handle it in ObjectArgumentValue. Or in separate PR? What do you think?

@sungam3r
Copy link
Contributor Author

ConfigurationReader has both _configurationAssemblies and _resolutionContext. If you are talking about refactoring their relationship and areas of responsibility then it should be in separate PR. You understand more than I am in this project and can do it better.

@skomis-mm
Copy link
Contributor

Ok. Will leave it for a few days before merge if someone else want to check.

@skomis-mm skomis-mm merged commit addaa41 into serilog:dev Mar 25, 2020
@sungam3r sungam3r deleted the collections-of-custom-types branch March 25, 2020 09:13
@sungam3r
Copy link
Contributor Author

When will release package be published on nuget?

@nblumhardt nblumhardt mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants