Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #223

Merged
merged 3 commits into from
May 26, 2020
Merged

Documentation update #223

merged 3 commits into from
May 26, 2020

Conversation

skomis-mm
Copy link
Contributor

@skomis-mm skomis-mm commented May 22, 2020

Readme.md was restructured to:

  1. Basic setup / config
  2. Syntax description and features
  3. Arguments binding
  4. Samples

CHANGES.md Outdated Show resolved Hide resolved
typo fix

Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@tsimbalar
Copy link
Member

Wow, great work to make newcomers life easiers, and really neat job on completing the documentation 👍

I'm now wondering if https://github.com/tsimbalar/serilog-settings-comparison still makes sens 🤔 (or at least I should try to update it with new supported features)

@skomis-mm
Copy link
Contributor Author

skomis-mm commented May 25, 2020

@tsimbalar IMO I think it makes sense to update serilog-settings-comparison. Documentation here is about basic syntax rules and features, tied to Microsoft.Settings.Configuration , but yours more focused on differences and how one configuration type can be replaced with other and what are the limits.

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skomis-mm skomis-mm merged commit 0624f63 into serilog:dev May 26, 2020
@nblumhardt nblumhardt mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Destructure config does not work in current Nuget release
4 participants