Drop support for .NET Framework 4.5.1 #351
Conversation
Support for .NET Framework 4, 4.5, and 4.5.1 [ended on January 12, 2016](https://learn.microsoft.com/en-GB/lifecycle/faq/dotnet-framework), that was 7 years ago! Also bump Microsoft.Extensions.Configuration.Binder and Microsoft.Extensions.DependencyModel to version 6.0.0 since version 2.0.0 and 3.0.0 respectively have been deprecated as part of the [.NET Package Deprecation effort](dotnet/announcements#217). Finally, this change allows to remove all conditional compilation. Note that removing a target framework is a breaking change so it will require a major version bump, i.e. 4.0.0.
|
Serilog itself has also dropped support for anything below .Net Framework 4.6.1 and .Net Standard 2.0 some time ago, so there is no expectation from that angle to keep supporting 4.5.1 either. |
|
4.6.1 is also EOL, why support it? Edit: I suppose bc the main project still supports it. |
|
Will this go into a 3.5 pre-release or is it too late for that? |
|
We should look at releasing this as 4.0.0 in the very near future 👍 |
|
I actually built this branch out and getting the same warning with 6.0.0 that I was with 3.0.0. I had to go to 7. I assume there is some nugget switch for >= on DependencyModel and Configuration Binder |
|
@0xced Any reason not to update |
|
According to this, the EOL of these packages might be bound to the corresponding framework, so perhaps 6.0.0 is best. Having said that, we still need a solution for #331 (comment). Does that lead us back to #339? |
|
@glen-84 end of the day the issues ends up being build images available on appveyor for net7? |
|
Additionally, I'm running the dependency with 3.0 on other 7.0 by ignoring the warning. Things seem to to be fine. So, 6.0 probably fine? |
|
Ignoring the warning is not a solution. |
@nblumhardt How near is very near? 🙂 |
Support for .NET Framework 4, 4.5, and 4.5.1 ended on January 12, 2016, that was 7 years ago!
Also bump Microsoft.Extensions.Configuration.Binder and Microsoft.Extensions.DependencyModel to version 6.0.0 since version 2.0.0 and 3.0.0 respectively have been deprecated as part of the .NET Package Deprecation effort.
Finally, this change allows to remove all conditional compilation.
Note that removing a target framework is a breaking change so it will require a major version bump, i.e. 4.0.0.