Make all JSON strings valid in tests #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can get rid of the `ToValidJson` extension method. Now that raw string literals have been introduced (in serilog#354) having valid _readable_ JSON in strings for tests becomes easy. There is no need to escape quotes anymore with either `\"` or `""`. This will also make it easier for newcomers to understand the tests at first glance. I had my WTF moment when I first saw JSON with single quotes. 🤔
So that your Integrated Development Environment (IDE) can perform nice syntax highlighting. See [Language injections in C#][1] in Rider for example. Also remove some trailing commas that were highlighted after adding the // language=json comment [1]: https://www.jetbrains.com/help/rider/Language_Injections.html
|
In the second commit I have also enabled JSON language injection (with How nice is it?
|
sungam3r
approved these changes
Mar 16, 2023
|
VS has syntax highlighting for JSON in raw string literals OOTB. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can get rid of the
ToValidJsonextension method.Now that raw string literals have been introduced (in #354) having valid readable JSON in strings for tests becomes easy. There is no need to escape quotes anymore with either
\"or"".This will also make it easier for newcomers to understand the tests at first glance. I had my WTF moment when I first saw JSON with single quotes. 🤔