Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify loading assemblies #379

Merged
merged 1 commit into from
May 5, 2023
Merged

Simplify loading assemblies #379

merged 1 commit into from
May 5, 2023

Commits on May 5, 2023

  1. Simplify loading assemblies 

    Use a HashSet instead of a Dictionary keyed by the assembly full name. If an assembly is loaded twice with the same AssemblyName it will be the same instance so a HashSet (without even a custom IEqualityComparer<Assembly>) is the perfect solution.

Also, Assembly.Load can throw many exceptions but won't return null.

This was initially introduced in 74402f8 but merged incorrectly in ac1b8c8.
    @0xced
    0xced committed May 5, 2023
    Configuration menu
    Copy the full SHA
    b98e589 View commit details
    Browse the repository at this point in the history