Prefer "MinimumLevel:Default" value if "MinimumLevel" value returns empty string #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MinimumLevel` is an empty string
sungam3r
reviewed
Mar 18, 2024
test/Serilog.Settings.Configuration.Tests/LoggerConfigurationExtensionsTests.cs
Outdated
Show resolved
Hide resolved
…xtensionsTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
approved these changes
Mar 18, 2024
|
Thanks for this @DavidAllardyce, sorry about the slow turnaround. I'd guess there are other places where this kind of behavior might affect us, which is a bit worrying, but the fix for this case looks contained/low-risk so let's get it into 8.0.3 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use value from
Serilog:MinimumLevel:Defaultif value fromSerilog:MinimumLevelis an empty string.Fixes #332