Add support for LoggingLevelSwitch #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Feb 12, 2018
| ApplyAuditSinks(loggerConfiguration, declaredLevelSwitches); | ||
| } | ||
|
|
||
| private IReadOnlyDictionary<string, LoggingLevelSwitch> ProcessLevelSwitchDeclarations() |
There was a problem hiding this comment.
Very minor nitpick- the Serilog repos don't use explicit private or internal (I think there might be a DotSettings file in the main repo.)
There was a problem hiding this comment.
yes indeed :) I'll copy over the .DotSettings file from the main repo to detect those cases.
|
Looks awesome 👍 Just added one minor nitpick - keen to get this to |
added 2 commits
February 13, 2018 08:28
solves serilog#69 Supports : - declaration of LoggingLevelSwitch - MinimumLevel.ControlledBy(switch) - MinimumLevel.Override(prefix, switch) - passing a switch by reference as the argument to a Sink (or any callable method)
Copy over .editorconfig and .sln.DotSettings from core repo Fix ReSharper red squigglies Fix remaining ReSharper warnings (possible multiple enumeration) Remove implicit "private" keywords
tsimbalar
force-pushed
the
loglevelswitchsupport
branch
from
12702d1 to
7034ca6
Compare
|
I've updated the code based on your comments :) |
|
🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69
Supports :
JSON syntax :
{ "Serilog": { "Using": [ "TestDummies" ], "LevelSwitches": { "$mySwitch": "Warning" }, "MinimumLevel": { "ControlledBy": "$mySwitch" }, "WriteTo": [ { "Name": "DummyWithLevelSwitch", "Args": { "controlLevelSwitch": "$mySwitch" } } ] } }but also overrides :
{ "Serilog": { "Using": [ "TestDummies" ], "LevelSwitches": { "$mySwitch": "Warning" }, "MinimumLevel": { "Default": "Information", "Override": { "Microsoft": "$mySwitch" } }, "WriteTo": [ { "Name": "DummyWithLevelSwitch", "Args": { "controlLevelSwitch": "$mySwitch" } } ] } }In order to implement "look up a switch by name", I had to change
IConfigurationArgumentValue's methodobject ConvertTo(Type toType)toobject ConvertTo(Type toType, IReadOnlyDictionary<string, LoggingLevelSwitch> declaredLevelSwitches)and cascade that change everywhere ...