Skip to content

Commit

Permalink
Merge pull request #122 from serilog/dev
Browse files Browse the repository at this point in the history
4.0.1 Release
  • Loading branch information
nblumhardt authored Nov 19, 2021
2 parents bdadace + c3231ab commit 37f02f5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 24 deletions.
29 changes: 8 additions & 21 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,25 +1,12 @@
**A few questions before you begin:**
Hi 👋

> Is this an issue related to the Serilog core project or one of the [sinks](https://github.com/serilog/serilog/wiki/Provided-Sinks) or [community projects](https://github.com/serilog/serilog/wiki/Community-Projects). This issue list is intended for Serilog core issues. If this issue relates to a sink or related project, please log on the related repository. Please use [Gitter chat](https://gitter.im/serilog/serilog) and [Stack Overflow](http://stackoverflow.com/questions/tagged/serilog) for discussions and questons.
If you have a question about using Serilog, or something isn't working as you expect it to, please post your question to the [`serilog` tag on Stack Overflow](https://stackoverflow.com/questions/tagged/serilog), where many more people are ready to help you out.

To report a bug or request a feature, please give us as much information as possible, for example:

**Does this issue relate to a new *feature* or an existing *bug*?**
- [ ] Bug
- [ ] New Feature
- [ ] the exact package id and version you're using,
- [ ] your `dotnet` toolchain version, target framework, and operating system,
- [ ] the current behavior, and
- [ ] what you expect or want to happen instead.

**What version of Serilog Console Sink is affected by this issue? Please list the related NuGet package.**

**What is the target framework and operating system affected by this issue? Please see [target frameworks](https://docs.microsoft.com/en-us/nuget/schema/target-frameworks) & [net standard matrix](https://docs.microsoft.com/en-us/dotnet/standard/net-standard).**

- [ ] netCore 2.0
- [ ] netCore 1.0
- [ ] 4.7
- [ ] 4.6.x
- [ ] 4.5.x

**Please describe the current behaviour you are experiencing?**

**Please describe the expected behaviour if the ?**

**If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem**
*NOTE: A small code sample goes a long way in expediting bug fixes or illustrating an enhancement you are proposing.*
Thanks!
2 changes: 1 addition & 1 deletion src/Serilog.Sinks.Console/Serilog.Sinks.Console.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<Description>A Serilog sink that writes log events to the console/terminal.</Description>
<VersionPrefix>4.0.0</VersionPrefix>
<VersionPrefix>4.0.1</VersionPrefix>
<Authors>Serilog Contributors</Authors>
<TargetFrameworks>net45;netstandard1.3;netstandard2.0;net5.0</TargetFrameworks>
<LangVersion>8.0</LangVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ public override void Render(LogEvent logEvent, TextWriter output)
var style = nextLine.StartsWith(StackFrameLinePrefix) ? ConsoleThemeStyle.SecondaryText : ConsoleThemeStyle.Text;
var _ = 0;
using (_theme.Apply(output, style, ref _))
output.WriteLine(nextLine);
output.Write(nextLine);
output.WriteLine();
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ int RenderPropertyToken(PropertyToken pt, IReadOnlyDictionary<string, LogEventPr

int RenderAlignedPropertyTokenUnbuffered(PropertyToken pt, TextWriter output, LogEventPropertyValue propertyValue)
{
if(pt.Alignment == null) throw new ArgumentException("The PropertyToken should have a non-null Alignment.", nameof(pt));
if (pt.Alignment == null) throw new ArgumentException("The PropertyToken should have a non-null Alignment.", nameof(pt));

var valueOutput = new StringWriter();
RenderValue(NoTheme, _unthemedValueFormatter, propertyValue, valueOutput, pt.Format);
Expand Down

0 comments on commit 37f02f5

Please sign in to comment.