Skip to content

Conversation

@skomis-mm
Copy link

@skomis-mm skomis-mm commented Nov 28, 2016

  • adds travis ci yml
  • fixes some tests failing on Linux (InvalidPath)
  • fixes tests failing sometimes due to racing around TempFolder on tests that have same name but are in different files (FileSink, SharedFileSink) while running in parallel

@nblumhardt
Copy link
Member

LGTM. CC @merbla, who has been looking after the core repo's Travis build.

@merbla
Copy link
Contributor

merbla commented Nov 29, 2016

Looks great!

Awesome job as per normal @skomis-mm

We may want to circle back once the tools are stable re: serilog/serilog#824

I have enabled the TravisCI here

@nblumhardt nblumhardt merged commit d5b2fa3 into serilog:dev Nov 29, 2016
@nblumhardt
Copy link
Member

Failing with:

/home/travis/build.sh: line 57: ./build.sh: Permission denied

https://travis-ci.org/serilog/serilog-sinks-file/jobs/179657892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants