Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit double quotes with one line #107

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

h8nor
Copy link
Contributor

@h8nor h8nor commented Jan 31, 2024

  • Limit double quotes with one line
  • Erase excess characters
  • Erase double quotes

Copy link
Owner

@serkonda7 serkonda7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! I have added comments for minor improvements and will merge it after they are resolved.

syntaxes/vba.yaml-tmlanguage Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@h8nor
Copy link
Contributor Author

h8nor commented Feb 2, 2024

What do you think about, could I count add in the extension?

  • Change the font on default editor VBA
  • Add in settings of the format restriction

@serkonda7
Copy link
Owner

Off topic: I hope I understood your comment correctly.
In case you want to use a tool to improve texts, I can recommend Deepl write https://www.deepl.com/de/write-mobile.
They also offer a great translator.

@serkonda7 serkonda7 merged commit aaf93e1 into serkonda7:main Feb 2, 2024
4 checks passed
serkonda7 added a commit that referenced this pull request Feb 2, 2024
@h8nor
Copy link
Contributor Author

h8nor commented Feb 2, 2024

Off topic: Thank you for link on the service.
I think we have a better understanding now. Then I will not contribute my settings from package.json.
https://code.visualstudio.com/api/references/contribution-points#contributes.configurationDefaults

{
	"contributes": {
		"configurationDefaults": {
			"[vba][wwb]": {
				...
			}
		}
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants