Skip to content

feat(editor-integration): add license chooser to save modal (keep) #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Mar 12, 2024

works quite well, unfortunately the backend currently ignores the setting 🤌

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Mar 12, 2024 5:09pm

Copy link
Contributor

github-actions bot commented Mar 12, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 489.84 KB (🟡 +183 B) 594.22 KB
/entity/create/[type]/[taxonomyId] 491.52 KB (🟡 +185 B) 595.89 KB
/entity/repository/add-revision/[...id] 490.73 KB (🟡 +182 B) 595.1 KB
/page/create 490.74 KB (🟡 +183 B) 595.12 KB
/taxonomy/term/create/[parent_id]/[id] 490.44 KB (🟡 +182 B) 594.81 KB
/taxonomy/term/update/[id] 490.35 KB (🟡 +184 B) 594.73 KB
/user/settings 489.09 KB (🟡 +184 B) 593.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho changed the title feat(editor-integration): add license chooser to save modal feat(editor-integration): add license chooser to save modal (keep) Mar 27, 2024
@elbotho
Copy link
Member Author

elbotho commented Mar 27, 2024

Closing for overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant