Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add interactive video plugin #4152

Draft
wants to merge 56 commits into
base: staging
Choose a base branch
from

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Sep 27, 2024

for PE-126, includes others from https://linear.app/serlo/project/feature-interaktives-video-81726f089728/issues

todos

  • allow selecting video
  • mobile testing (functional)
  • user testing
  • check bundle size increase

review notes

There is one feature that needed some complexity. The interactive video events needs to know how learners interact with the exercises within the overlays. This is the simplest solution I could come up with:

Video library:
We use @vidstack/react as a player. It has pretty good support for different providers / formats, looks great and DX was pretty nice so far. (Some background in this issue)
We basically use the default theme as much as possible. In theory we could use the same player setup for the video plugin now. All custom UI is injected into the player via slots (docs). Usually you only have access to the player (e.g. via useMediaPlayer()) inside those injected elements, or custom event hooks (via useMediaRemote().getPlayer(target) – example in useCheckSeekAndPlay()).
Outside of that the player is not (easily) accessible.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Oct 17, 2024 3:14pm

Copy link
Contributor

github-actions bot commented Sep 27, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 105.07 KB (🟡 +491 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 86.34 KB (🟡 +209 B) 191.4 KB
/404 43 KB (🟡 +209 B) 148.06 KB
/500 42.99 KB (🟡 +209 B) 148.06 KB
/[...slug] 87.16 KB (🟡 +368 B) 192.23 KB
/___bot_or_not 101.41 KB (🟡 +186 B) 206.48 KB
/___cf_not_found 41.23 KB (🟡 +209 B) 146.3 KB
/___design 146.54 KB (🟡 +209 B) 251.6 KB
/___editor_preview 668.46 KB (🟡 +109 KB) 773.53 KB
/___old_comments 103.45 KB (🟢 -185 B) 208.51 KB
/auth/___activate_vidis 41.53 KB (🟡 +209 B) 146.6 KB
/auth/error 66.84 KB (🟡 +209 B) 171.9 KB
/auth/login 94.53 KB (🟡 +209 B) 199.6 KB
/auth/logout 85.27 KB (🟡 +209 B) 190.33 KB
/auth/oauth/consent 59.1 KB (🟡 +209 B) 164.17 KB
/auth/oauth/login 94.54 KB (🟡 +209 B) 199.61 KB
/auth/oauth/logout 85.27 KB (🟡 +209 B) 190.34 KB
/auth/recovery 76.2 KB (🟡 +209 B) 181.26 KB
/auth/registration 76.96 KB (🟡 +209 B) 182.03 KB
/auth/settings 77.07 KB (🟡 +209 B) 182.14 KB
/auth/verification 76.35 KB (🟡 +209 B) 181.42 KB
/authorization/roles 70.95 KB (🟡 +210 B) 176.02 KB
/backend 43.29 KB (🟡 +209 B) 148.36 KB
/biologie 155.7 KB (🟡 +368 B) 260.77 KB
/chemie 155.7 KB (🟡 +368 B) 260.77 KB
/consent 41.82 KB (🟡 +209 B) 146.89 KB
/content-only/[...slug] 79.2 KB (🟡 +368 B) 184.27 KB
/discussions 99.98 KB (🟢 -588 B) 205.05 KB
/editor 79.98 KB (🟡 +375 B) 185.05 KB
/entity/create/[type]/[taxonomyId] 670.69 KB (🟡 +109 KB) 775.75 KB
/entity/license/update/[id] 61.12 KB (🟡 +209 B) 166.18 KB
/entity/repository/add-revision/[...id] 670.37 KB (🟡 +109 KB) 775.44 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.9 KB (🟡 +368 B) 196.97 KB
/entity/repository/history/[id] 74.46 KB (🟡 +210 B) 179.52 KB
/entity/taxonomy/update/[id] 73.6 KB (🟡 +210 B) 178.67 KB
/entity/unrevised 48.06 KB (🟢 -232 B) 153.13 KB
/event/history 127.21 KB (🟡 +126 B) 232.28 KB
/event/history/[...slug] 128.18 KB (🟡 +99 B) 233.25 KB
/event/history/user/profile/[username] 130.56 KB (🟢 -395 B) 235.63 KB
/gleichungs-app 165.31 KB (🟡 +209 B) 270.38 KB
/informatik 155.7 KB (🟡 +368 B) 260.77 KB
/jobs/[[...jobId]] 52.5 KB (🟡 +209 B) 157.56 KB
/legal 41.3 KB (🟡 +209 B) 146.37 KB
/lerntipps 155.7 KB (🟡 +368 B) 260.77 KB
/license/detail/[id] 67.12 KB (🟡 +368 B) 172.19 KB
/mathe 155.7 KB (🟡 +368 B) 260.76 KB
/mathe-aufgaben 42.02 KB (🟡 +209 B) 147.08 KB
/mathe-pruefungen/[region] 78.37 KB (🟡 +209 B) 183.44 KB
/metadata 51.1 KB (🟡 +209 B) 156.17 KB
/nachhaltigkeit 155.71 KB (🟡 +368 B) 260.77 KB
/page/create 670.38 KB (🟡 +109 KB) 775.45 KB
/pages 62.43 KB (🟡 +209 B) 167.5 KB
/privacy 44.94 KB (🟡 +209 B) 150 KB
/search 43.29 KB (🟡 +209 B) 148.36 KB
/spenden 55.68 KB (🟡 +209 B) 160.75 KB
/subscriptions/manage 110.3 KB (🟡 +210 B) 215.37 KB
/taxonomy/term/[copyOrMove]/batch/[id] 76.27 KB (🟡 +263 B) 181.34 KB
/taxonomy/term/create/[parent_id]/[id] 670.11 KB (🟡 +109 KB) 775.18 KB
/taxonomy/term/sort/entities/[id] 98 KB (🟡 +266 B) 203.06 KB
/taxonomy/term/update/[id] 670.03 KB (🟡 +109 KB) 775.1 KB
/team 49.2 KB (🟡 +209 B) 154.27 KB
/terms 41.32 KB (🟡 +209 B) 146.39 KB
/user/[...userslug] 41.12 KB (🟡 +209 B) 146.19 KB
/user/me 41.11 KB (🟡 +209 B) 146.18 KB
/user/notifications 129.53 KB (🟡 +137 B) 234.6 KB
/user/profile/[username] 178.21 KB (🟢 -120 B) 283.28 KB
/user/settings 669.24 KB (🟡 +109 KB) 774.31 KB
/uuid/recycle-bin 84.67 KB (🟡 +210 B) 189.74 KB
/wallet 44 KB (🟡 +209 B) 149.07 KB
/willkommen 88.25 KB (🟡 +228 B) 193.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant