Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use editor package in frontend (WIP) #4380

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Dec 30, 2024

Linear issue: EDTR-104

As a first step, all editor imports should point to '@editor/package'. Then in the end, these can all be replaced by '@serlo/editor'.

Current open questions/todos:

  • What to do with SerloOnlyFeaturesContext?

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Jan 3, 2025 11:31am

Copy link
Contributor

github-actions bot commented Dec 30, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 104.51 KB (🟢 -397 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/___editor_package_preview 531.62 KB 636.13 KB

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 85.55 KB (🟡 +17 B) 190.05 KB
/404 42.24 KB (🟡 +16 B) 146.75 KB
/500 42.23 KB (🟡 +16 B) 146.74 KB
/[...slug] 556.21 KB (🔴 +461.3 KB) 660.72 KB
/___bot_or_not 565.99 KB (🔴 +459.63 KB) 670.5 KB
/___cf_not_found 40.46 KB (🟡 +16 B) 144.96 KB
/___design 145.75 KB (🟡 +14 B) 250.26 KB
/___editor_preview 695.97 KB (🟡 +32.16 KB) 800.48 KB
/___old_comments 99.51 KB (🟡 +6 B) 204.02 KB
/auth/___activate_vidis 40.75 KB (🟡 +17 B) 145.25 KB
/auth/error 65.28 KB (🟡 +17 B) 169.78 KB
/auth/login 89.88 KB (🟡 +16 B) 194.38 KB
/auth/logout 80.58 KB (🟡 +15 B) 185.09 KB
/auth/oauth/consent 55.19 KB (🟡 +18 B) 159.7 KB
/auth/oauth/login 89.88 KB (🟡 +16 B) 194.39 KB
/auth/oauth/logout 80.59 KB (🟡 +16 B) 185.1 KB
/auth/recovery 74.64 KB (🟡 +16 B) 179.15 KB
/auth/registration 75.44 KB (🟡 +15 B) 179.95 KB
/auth/settings 75.52 KB (🟡 +15 B) 180.03 KB
/auth/verification 74.8 KB (🟡 +15 B) 179.31 KB
/authorization/roles 66.9 KB (🟡 +17 B) 171.41 KB
/backend 42.52 KB (🟡 +19 B) 147.03 KB
/biologie 624.95 KB (🔴 +461.36 KB) 729.46 KB
/chemie 624.95 KB (🔴 +461.36 KB) 729.46 KB
/consent 41.03 KB (🟡 +16 B) 145.54 KB
/content-only/[...slug] 548.32 KB (🔴 +461.32 KB) 652.83 KB
/discussions 96.05 KB (🟡 +2 B) 200.56 KB
/editor 549.95 KB (🔴 +462.13 KB) 654.46 KB
/entity/create/[type]/[taxonomyId] 592.41 KB (🟢 -91.69 KB) 696.91 KB
/entity/license/update/[id] 57.23 KB (🟡 +16 B) 161.74 KB
/entity/repository/add-revision/[...id] 592.07 KB (🟢 -91.75 KB) 696.58 KB
/entity/repository/compare/[entity_id]/[revision_id] 560.89 KB (🔴 +461.33 KB) 665.4 KB
/entity/repository/history/[id] 69.98 KB (🟡 +11 B) 174.49 KB
/entity/taxonomy/update/[id] 70.02 KB (🟡 +509 B) 174.53 KB
/entity/unrevised 47.29 KB (🟡 +17 B) 151.8 KB
/event/history 123.38 KB (🟡 +55 B) 227.88 KB
/event/history/[...slug] 124.36 KB (🟡 +56 B) 228.86 KB
/event/history/user/profile/[username] 126.75 KB (🟡 +55 B) 231.25 KB
/gleichungs-app 164.31 KB (🟡 +13 B) 268.82 KB
/informatik 624.95 KB (🔴 +461.36 KB) 729.46 KB
/jobs/[[...jobId]] 51.73 KB (🟡 +14 B) 156.23 KB
/legal 40.52 KB (🟡 +15 B) 145.02 KB
/lerntipps 624.95 KB (🔴 +461.36 KB) 729.46 KB
/license/detail/[id] 537.19 KB (🔴 +462.33 KB) 641.7 KB
/mathe 624.95 KB (🔴 +461.36 KB) 729.46 KB
/mathe-aufgaben 41.26 KB (🟡 +16 B) 145.76 KB
/mathe-pruefungen/[region] 77.63 KB (🟡 +17 B) 182.13 KB
/metadata 50.16 KB (🟡 +16 B) 154.67 KB
/nachhaltigkeit 624.96 KB (🔴 +461.36 KB) 729.46 KB
/page/create 592.08 KB (🟢 -91.73 KB) 696.58 KB
/pages 58.54 KB (🟡 +15 B) 163.05 KB
/privacy 44.19 KB (🟡 +16 B) 148.69 KB
/search 42.52 KB (🟡 +17 B) 147.03 KB
/spenden 54.87 KB (🟡 +32 B) 159.38 KB
/subscriptions/manage 106.45 KB (🟡 +58 B) 210.96 KB
/taxonomy/term/[copyOrMove]/batch/[id] 84.13 KB (🟢 -94 B) 188.64 KB
/taxonomy/term/create/[parent_id]/[id] 591.78 KB (🟢 -91.78 KB) 696.29 KB
/taxonomy/term/sort/entities/[id] 91.86 KB (🟢 -114 B) 196.37 KB
/taxonomy/term/update/[id] 591.7 KB (🟢 -91.81 KB) 696.21 KB
/team 48.26 KB (🟡 +16 B) 152.76 KB
/terms 40.54 KB (🟡 +15 B) 145.04 KB
/user/[...userslug] 40.34 KB (🟡 +17 B) 144.85 KB
/user/me 40.33 KB (🟡 +16 B) 144.84 KB
/user/notifications 125.71 KB (🟡 +56 B) 230.22 KB
/user/profile/[username] 629.87 KB (🔴 +447.22 KB) 734.38 KB
/user/settings 569.08 KB (🟢 -116.4 KB) 673.59 KB
/uuid/recycle-bin 80.65 KB (🟡 +15 B) 185.16 KB
/wallet 43.24 KB (🟡 +16 B) 147.75 KB
/willkommen 86.7 KB (🟡 +17 B) 191.21 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant