Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ts-results-es #366

Merged
merged 6 commits into from
Aug 11, 2024
Merged

refactor: remove ts-results-es #366

merged 6 commits into from
Aug 11, 2024

Conversation

jacoobes
Copy link
Member

ts-results-es, although rich in features, has too many things we don't need anymore, and I've decided to opt in for a simpler in house implementation.

@jacoobes jacoobes requested a review from DuroCodes August 11, 2024 05:16
@DuroCodes
Copy link
Contributor

Is there any reason to have the isOk function? couldn't you just check result.ok?

Once you check result.ok, its should infer that the result is { ok: true, value: T }

Signed-off-by: Jacob Nguyen <76754747+jacoobes@users.noreply.github.com>
Signed-off-by: Jacob Nguyen <76754747+jacoobes@users.noreply.github.com>
Copy link
Contributor

@DuroCodes DuroCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

@jacoobes jacoobes merged commit 61e82fd into main Aug 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants