Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localPack not parsing correctly #113

Closed
Human018 opened this issue Oct 13, 2018 · 1 comment
Closed

localPack not parsing correctly #113

Human018 opened this issue Oct 13, 2018 · 1 comment

Comments

@Human018
Copy link

Whenever I've performed a search which returns local listing (map listings) the Map parser always returns the first local listing url for all three listings.

The issue seems to be in /serps/search-engine-google/src/Parser/Evaluated/Rule/Natural/Map.php file, line 62.

$nodes = $dom->cssQuery('a.L48Cpd');

It is missing the $localPack variable to narrow the href search to the current array index, from what I see (and my tests) this line should be:

$nodes = $dom->cssQuery('a.L48Cpd', $localPack);
gsouf added a commit that referenced this issue Oct 29, 2018
@gsouf
Copy link
Member

gsouf commented Oct 29, 2018

Hi @Human018

Thanks for reporting and sorry for the delay. That's a good catch! You'll find it fixed in version 0.4.5

@gsouf gsouf closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants