Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with parallel_tests v4 #28

Closed
franzliedke opened this issue Mar 23, 2023 · 3 comments · Fixed by #29
Closed

Compatibility with parallel_tests v4 #28

franzliedke opened this issue Mar 23, 2023 · 3 comments · Fixed by #29

Comments

@franzliedke
Copy link
Contributor

Can we get a new release compatible with version 4 of parallel_tests which was released last November? 🙏🏼
@ilyazub
Copy link
Collaborator

ilyazub commented Mar 24, 2023

Hi @franzliedke,

Which change are you interested in to be ported: grosser/parallel_tests#891 or grosser/parallel_tests#884?

@franzliedke
Copy link
Contributor Author

Neither, really. It's more about this constraint in the gemspec:

turbo_tests/turbo_tests.gemspec

Line 23 in ec37cee

spec.add_dependency "parallel_tests", "~> 3.3"

That's causing GitHub's dependabot to downgrade turbo_tests to version 1.0.0 (which doesn't have a version constraint) as part of an upgrade of parallel_tests to v4. 😆

@ilyazub
Copy link
Collaborator

ilyazub commented Mar 28, 2023

Makes sense :-) Please submit a PR with dependency upgrade. If tests will pass, it should be good to go.

@franzliedke franzliedke mentioned this issue Mar 30, 2023
Merged
@ilyazub ilyazub mentioned this issue Sep 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Claim compatibility with parallel_tests v4 franzliedke/turbo_tests
2 participants
@franzliedke @ilyazub