Prepend env in command output #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Oct 26, 2022
grosser
reviewed
Oct 27, 2022
grosser
reviewed
Oct 27, 2022
lib/parallel_tests/cli.rb
Outdated
| command = @runner.command_with_seed(command, failing_set[:seed]) if failing_set[:seed] | ||
| puts Shellwords.shelljoin(command) | ||
| env_str = "TEST_ENV_NUMBER=#{env['TEST_ENV_NUMBER']} PARALLEL_TEST_GROUPS=#{env['PARALLEL_TEST_GROUPS']}" |
There was a problem hiding this comment.
Suggested change
| env_str = "TEST_ENV_NUMBER=#{env['TEST_ENV_NUMBER']} PARALLEL_TEST_GROUPS=#{env['PARALLEL_TEST_GROUPS']}" | |
| env_str = ["TEST_ENV_NUMBER", "PARALLEL_TEST_GROUPS"].map { |e| "#{e}=#{env[e]}" }.join(" ") |
There was a problem hiding this comment.
... do we even need PARALLEL_TEST_GROUPS ?
I think the reason for this PR was that the re-run did not hit the same db or something like that ?
There was a problem hiding this comment.
I guess yes. Will be useful when --only-group is used. Otherwise, it will be difficult to differentiate commands.
grosser
reviewed
Oct 27, 2022
… command output in --verbose
adis-io
force-pushed
the
patch-1
branch
2 times, most recently
from
f6283f9
to
9de57ce
Compare
|
4.0.0 |
mcmoyer
added a commit
to mcmoyer/parallel_tests
that referenced
this pull request
Mar 23, 2023
PR [grosser#884](grosser#884) combined both `verbose-process-command` and `verbose-rerun-command` into `verbose-command` This PR updates the Readme to reflect that change
grosser
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines
--verbose-process-commandand--verbose-rerun-commandinto singel--verbose-command.Also
TEST_ENV_NUMBERandPARALLEL_TEST_GROUPSenvironment variables added to command output. Useful for debugging purposes.Before:
After:
Checklist
master(if not - rebase it).code introduces user-observable changes.