Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --runtime-log option #16

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Add --runtime-log option #16

merged 1 commit into from
Oct 4, 2021

Conversation

AMHOL
Copy link
Contributor

@AMHOL AMHOL commented Sep 29, 2021

No description provided.

ilyazub
ilyazub reviewed Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AMHOL!

Why do you want to change the runtime log path?

@AMHOL
Copy link
Contributor Author

AMHOL commented Sep 29, 2021

@ilyazub with my current setup, it makes it easier to cache between builds, the Rails tmp directory is wiped between builds, so storing it in a different directory makes life much easier (and cheaper).

@AMHOL
Copy link
Contributor Author

AMHOL commented Oct 4, 2021

@ilyazub is this something you'd consider merging or should I close the PR and find an alternate method?

ilyazub
ilyazub approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. @AMHOL, thanks for the explanation.

Also, parallel_tests have the runtime-log option and turbo_tests mirrors a part of options from it.

@ilyazub ilyazub merged commit 4d1e261 into serpapi:master Oct 4, 2021
@AMHOL
Copy link
Contributor Author

AMHOL commented Oct 5, 2021

TY @ilyazub

@AMHOL AMHOL deleted the feature/custom-runtime-log branch October 5, 2021 01:16
@ilyazub ilyazub mentioned this pull request Mar 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyazub ilyazub ilyazub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AMHOL @ilyazub