Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --nice flag #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --nice flag #44

wants to merge 1 commit into from

Conversation

Bo98
Copy link

@Bo98 Bo98 commented Dec 17, 2023

ilyazub
ilyazub reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98, thanks for all of the improvements! Apologies I didn't review it sooner. I was on vacation and then getting up to speed.

I'll review your PRs, share the feedback, and merge the ones that look good.

ilyazub
ilyazub requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @Bo98!

Let's support all of the ParallelTests options instead by calling ParallelTests::CLI.send(:parse_options!, @argv) in TurboTests::CLI#run (ref: #41 (review)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyazub ilyazub ilyazub requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bo98 @ilyazub